On 2012-07-27 15:24, Bertrik Sikken wrote:

* Applying global gain from the opus audio file is not implemented
   (not sure if replaygain is working)

Fixed (it's part of the codec, not related to replaygain although we
might want to implement replaygain for e.g. vorbis too).

Thanks.

(Replaygain for vorbis/upus doesn't look that complicated really, BTW).

A call to codec_set_replaygain() when starting a new track should be enough. It looks like the existing tag parsing code is used; if so Replaygain tags are already handled.

By the way, how is resampling handled? From what I've read, Opus always uses 48 kHz internally, so what resampler is used? The one in Opus or the one in Rockbox?

--
  Magnus

Reply via email to