sounds good. i'll try and get my stuff ready for an initial commit in the next couple days, that way you can try merging it into the 2.0 branch as soon as possible.
i do have 1 other semi-fundamental change that will likely be required to make the theme management stuff work, and that is a change to the way a website default page currently works. basically, with the fact that themes are becoming sharable it changes the way the a default page will work. the example being that someone could potentially have 0 page templates because they use a shared theme and haven't created any custom templates. i am still trying to figure out exactly what changes are needed, but it'll probably take me a little while longer to fully wrap my head around it. I don't think this will require any renaming, but it may mean a little bit of adding/removing of methods. i'll keep you posted as i move forward so hopefully i won't step on anything you are doing. -- Allen On Wed, 2005-06-29 at 09:47, Dave Johnson wrote: > I'm OK with the WeblogTemplate rename and I'd like to do more, but we > need to careful with renaming right now. I'm doing major surgery (i.e. > a giant number of changes) on Roller in the Roller 2.0 branch to > introduce group blogging and a many-to-many relationship between user > and website. Rename will make my merge much more difficult, so let's > not go to town right now. > > And yes, the *Data and *Assoc patterns are used in the XDoclet stuff. > > - Dave > > > On Jun 29, 2005, at 9:24 AM, Allen Gilliland wrote: > > >> From what I can tell the only thing that the *Data convention really > >> helps is the xdoclet calls. I've actually tested the change from > >> PageData to WeblogTemplate and the only part that took a little > >> finessing was the xdoclet calls. > > > > Personally, I prefer that we just choose the best possible names for > > the classes rather than always try and follow the *Data convention. > > > > -- Allen > > > > > > On Wed, 2005-06-29 at 08:06, Anil Gangolli wrote: > >> Actually, we may be using *Data as a pattern for applying Xdoclet. > >> I'm not in a position to check the sources right now. But this > >> is something to check. > >> > >> --a. > >> > >> > >> ----- Original Message ----- > >> From: "Anil Gangolli" <[EMAIL PROTECTED]> > >> To: <[email protected]> > >> Sent: Wednesday, June 29, 2005 8:04 AM > >> Subject: Re: rename PageData to WeblogTemplate? > >> > >> > >>> > >>> I thought the "*Data" suffix pattern is currently used on all of the > >>> pojos deriving from PersistentObject. Following this, you > >>> would have WeblogTemplateData. Are we moving away from this? I'm > >>> not sure if it adds value any longer, but I think we should > >>> make it a conscious decision to move away from that pattern on the > >>> whole (which would be ok with me). > >>> > >>> --a. > >>> > >>> > >>> ----- Original Message ----- > >>> From: "Allen Gilliland" <[EMAIL PROTECTED]> > >>> To: "roller-dev" <[email protected]> > >>> Sent: Tuesday, June 28, 2005 4:19 PM > >>> Subject: rename PageData to WeblogTemplate? > >>> > >>> > >>>> would anybody be upset if I renamed the PageData class to > >>>> WeblogTemplate? I figured that since I am already having to do > >>>> some > >>>> alterations to make way for theme templates that it would be nice > >>>> to be consistent. > >>>> > >>>> Right now I have ... > >>>> > >>>> Template (interface) > >>>> - ThemeTemplate (implements Template) > >>>> > >>>> Then I would rename PageData to WeblogTemplate to follow the > >>>> pattern. WeblogTemplate seems pretty good since it is basically a > >>>> template that is attached to a specific weblog. This won't > >>>> actually change any functionality, just a naming thing really. > >>>> > >>>> -- Allen > >>>> > >>>> > >>> > >> >
