I think there are still a number of improvements that need to be made to the db scripts process, so i've outlined a few concerns/ideas ...
1. I don't like that we set the list of template files to be processed in each control file individually. This is redundant and error prone because it's possible that someone could forget to add a new template for a given database. Shouldn't that be kept in a master file that applies to all control files? 2. Same as above, I don't like that we include that foreach loop at the bottom of each control file. I also think this should be in a more centralized master control file. 3. I also don't like that we have a macro definition in the 200-210 migration script. I think the macros should once again be part of the master control file. Then if a specific migration script really needs to override the default version of a macro then it can do so. So putting that all together I am thinking we should modify the approach so that the script generation process is started by some master control file. In that file we set the list of templates to process, a list of various macro definitions, and then put a loop that iterates through each control file and processes each template file for that control. Also, what happened to all the old db scripts? Are we not planning to include them in releases after Roller 2.0? -- Allen
