On Apr 19, 2006, at 6:24 PM, Allen Gilliland wrote:
I'm not sure that I agree with your approach on this fix.
It seems a little obscure to tie the basic functionality of the
saveWebsite(website) function together with the special case where
you are updating all entries with some comment settings. Plus, the
update logic that you are executing is happening on weblog entries
and not the website object itself, so it probably makes more sense
for that method to be in the WeblogManager.
I think a better approach would be to revert the saveWebsite()
method back to the way it was, then add a new method to the
WeblogManager that is something like modifyAllEntries(weblog, attr,
attr, etc). Then in the WebsiteFormAction class you would save the
website as usual, and *if* the person has checked the "apply to all
entries" box then you would make a call to that modifyAllEntries()
method.
Does that make sense?
Yes. That makes *much* more sense. I'm going to make that change.
- Dave
