Jeff,

Could I convince you to please merge in Allen's changes, which were just committed to the trunk, and then resubmit your patch? I'll should have some time in the next day or so to take a look at it.

- Dave



On Apr 18, 2006, at 6:57 PM, Jeff Blattman wrote:
see attached 4.2 patch file ...

7. roller now requires that the datecreated field is set when creating a weblog. change RollerUserHandler to add date-created field into WeblogEntry object, if it's not present

8. fixed bug where URIs of the type .../members/<handle> were not being accepted. this URI should list of the members for weblog handle <handle> (this is a regression from #6 below)

9. fixed bug where the Roller*Handler classes were returning exactly what the user passed in for put and post request. they are supposed to return the complete, populated newly created or updated entries. e.g., the user doesn't pass in "date created" when they create a weblog, but they would expect it to be returned.

10. change namespace from .../atom/aapp to .../roller/aapp

Jeff Blattman wrote:
is it possible for someone to review / commit this patch? not trying to rush anyone, just not sure if this got missed. feel free to tell me to go away if it's crunch time for other aspects of the project.

new version of the patch is attached (4.1) ... in addition to 1-3 below,

4. make weblog entries contain the APP URLs as a field
5. add new class AppUrl for constructing roller APP URLs
6. change URI parsing to be based on regex not string splitting




Jeff Blattman wrote:
summary of changes:
do not return the user password field to client
in PUTs, password is an optional field. previously, clients HAD TO pass in the user password to update. obviously, combined w/ #1, this is a problem, because it would require them to update the password to a new value refactor auth framework / classes. no change in functionality, just re-factoring to be cleaner (this is the bulk of the patch)
patch file is attached (rooted at roller/trunk).
<aapp-4.2.patch.gz>

Reply via email to