Thanks Henri, comments are in line.
On May 11, 2006, at 4:11 AM, Henri Yandell wrote:
* PGP/MD5.
I'm waiting for some guidance on this one. Can I create the tar balls
and then sign them later?
* The LICENSE.txt contains a disclaimer including LGPL components that
can be removed.
Fixed for RC3.
* No NOTICE.txt file.
Fixed for RC3.
* tools/lib contains jars it shouldn't. ekit, mail and activation
jumped out. Though SourceForge does suggest that ekit is asl 2.0/lgpl
dual licensed now. You mention it's removed above though.
Removed mail, activation ekit for RC3.
* Is ./tools/buildtime/ejb-1.1.jar okay license wise?
Removed for RC3.
* No information on how to build. ie) the bit about going to get the
hibernate jars (and anything else that's needed - hibernate is what it
falls over to start with).
Build and source code access instructions are currently on the wiki.
* The following files lack 'LICENSE-2.0' in their text:
./src/org/apache/roller/presentation/tags/LinkParamTag.java
./src/org/apache/roller/presentation/tags/LinkTag.java
./src/org/apache/roller/presentation/util/
CacheHttpServletResponseWrapper.java
./src/org/apache/roller/presentation/util/ResponseContent.java
./src/org/apache/roller/presentation/util/SplitPrintWriter.java
./src/org/apache/roller/presentation/util/
SplitServletOutputStream.java
./src/org/apache/roller/util/Utilities.java
For those files, can we simply list the copyright holders in the
NOTICE file?
./tests/org/apache/roller/ant/StartHsqldbTask.java
./tests/org/apache/roller/ant/StopHsqldbTask.java
./tests/org/apache/roller/business/BookmarkTest.java
./tests/org/apache/roller/RollerTestBase.java
./tests/org/apache/roller/TestUtils.java
...
I added headers to all the test files for RC3.
- Dave
