On 12/1/06, Allen Gilliland <[EMAIL PROTECTED]> wrote:
Dave wrote: > On 12/1/06, Allen Gilliland <[EMAIL PROTECTED]> wrote: >> After doing some debugging on a db connection leak problem I have found >> that the problem is actually originating from our 404.jsp (and likely >> our 403.jsp and error.jsp to a lesser degree). I'm not sure exactly why >> the problem occurs, but for a while now we have been seen slow leaking >> of db connections in our connection pool and after removing that custom >> 404.jsp the problem has gone away. >> >> I imagine that most people haven't noticed this because it takes a fair >> amount of traffic to tickle the problem. It seems that it's not >> occurring on all 404 responses, only under certain conditions. In any >> case I want to fix the problem in Roller and so there are 2 options ... >> >> 1. Remove the 404.jsp outright and just leave it up to users to >> implement a custom 404 page if they want to. >> >> 2. Change the 404.jsp somehow to not cause the problem. This would >> basically mean simplifying it so that it doesn't require a db Session >> like it does now. >> >> Does anyone have any preference? I would probably vote for #1 because I >> think that custom 404 pages are something users can do if they really >> want them. I have never found a lot of use for them. > > I vote for #2. Roller should provide a nice happy 404 page right out > of the box. And I'd like to understand why a simple JSP Is causing a > connection leak. I would like to know that too, but I don't really feel the need to spend too much time on it. I am fine with leaving the 404 page in there, but what I'm going to do is remove the tiles definitions and make the page more generic and not include the bannerStatus stuff. I don't think that stuff really fits with the 404 page anyways because 404s are generated from all over the application, not just in the UI.
Yeah. We should make the 404 pages nice lookin' but drop dead simple, i.e. they shouldn't require a DB connection. And they should set status 404, not 200 as John points out. - Dave
