Mitesh Meswani wrote:
Hi Allen,
*snip*
Following are callers of this method.
login-redirect.jsp ()
WeblogsPager.getItems() (org.apache.roller.ui.rendering.pagers)
login-redirect.jsp ()
PermissionTest.testInvitations()(2 usages) (org.apache.roller.business)
SyncWebsitesTask.runTask() (org.apache.roller.planet.tasks)
BloggerAPIHandler.getUsersBlogs(String, String, String)
(org.apache.roller.webservices.xmlrpc)
SiteModel.getNewWeblogs(int, int) (org.apache.roller.ui.rendering.model)
WeblogTest.testWeblogLookups()(5 usages) (org.apache.roller.business)
All of them pass a null as value of endDate to this method. So,
effectively we are never using the parameter. Do you think it makes
sense to change signature of this method to remove endDate?
well, I think it's fine if we just leave it alone. It's not hurting
anything right now and there may be potential uses for it in the future.
Plus, it seems like wasted effort to go through the effort to take it
out of the method signature.
-- Allen
Regards,
Mitesh
if (enabled != null) {
criteria.add(Expression.eq("enabled", enabled));
}
@@ -496,7 +500,9 @@
criteria.setMaxResults(length);
}
criteria.addOrder(Order.desc("dateCreated"));
+ return criteria.list();
+ } catch (HibernateException e) {
throw new RollerException(e);
}
