Technical discussion of the last few commits, for anyone interested:
In "classic" Citadel there were several different address formats:
1. Display name
2. Display name @ node
3. Display name <n...@domain.com>
The second format is clearly obsolete now that there is no more CitaNet
support.
Since dialup and UUCP ended years ago, we're now assuming that there's always
going to be the Internet, or at least something using the protocols of the
Internet.
With the most recent update to the inbox rules handler, I found that some
code paths choke on the first format as well. It needs an address. Over
the last year, we've changed things around so that every user has at least
one Internet-format email address even when they don't have or use Internet
email. It functions exactly the same as the "User Principal Name" in Active
Directory, and is not
fungible. It will always be <user_n...@primary.fqdn.com> even if the user
has a primary email address that is something else.
This UPN is also the user's address on an XMPP network, and in the future
it will be their address on protocols such as ActivityPub or whatever. It
gives the code something to chew on when it assumes address format #3 is in
use.
I've removed the display of "@ node" and "@ node (hnode)" address formats,
because Citadel Server doesn't generate those anymore. The problem is that
we're now generating all messages in address format #3, even if they are just
local message board posts. So we're seeing nuisance headers like:
2020-12-12 18:45 from IGnatius T Foobaz
<ignatius_t_foo...@frobozz.example.com>
I don't want to blast that syntax out at all the users. So now that the
legacy formats are gone, the next thing to do is suppress the display of
the address or UPN when it isn't needed. I think that will basically take
the form of, suppress the display of the address portion when the domain is
local.
