[Citadel Development] Re: Merge Request Approval: IMAP memory issues with use of ConstStr

[IGnatius T Foobar]

 >Not sure why the parameter was empty, but a lot of code accessed ConstStr
 
 >pointers without checking for zero length and pointer was null and could
 
 >coredump, so went through and added checks.  
  
 *sigh* 
  
 The IMAP server was written completely with straight C pointers and string
buffers and it was extensively tested as it was built.  Unfortunately, the
developer who added StrBuf and ConstStr to libcitadel was a little too eager
and converted a lot of code all throughout the system, and introduced subtle
bugs everywhere.