Kudos to you for this change. If i may have a little thing to add, i think the scritp, in case no obj/output dir and makefile.auto is found in current dir, should prompt about cleaning the tree from default location, instead of doing it automagically. Simple yes/no would suffice and all would be perfect.
Best regards 2009/11/27 Colin Finck <m...@colinfinck.de> > Hi everybody, > > The "clean" command in RosBE has often been criticized for not cleaning > what > the user expected. > While in the past, it had just issued commands to delete the four > files/folders "makefile.auto", "obj-i386", "output-i386" and "reactos" in > the current directory, it's general behaviour has been changed > significantly > over time, in particular by these two commits: > > - 38756 > If you set a different object or output directory for the built files > through RosBE Options, these directories are always cleaned instead of > "obj-i386" or "output-i386" in the current directory. > > - 39138 > If no dedicated object or output directory is set through RosBE Options, > we always clean the one set after RosBE has been started or which has been > set by "chdefdir". We even do so if this directory is not the current > working directory. > > Especially the latter commit seems to have caused problems for many people > as you could easily clean the wrong tree now. > Therefore I made some efforts to rework this command a bit and published by > current script at http://reactos.colinfinck.de. > > This script now first checks whether "makefile.auto", "obj-i386", > "output-i386" and "reactos" exist in the current directory. If all of them > exist, they are cleaned. > If not, it checks whether different object and output directories were set > using RosBE Options and checks for them instead of "obj-i386" and > "output-i386". If they exist together with "makefile.auto" and "reactos" in > the current working directory, all of them are cleaned. > Of course, this also works for every other architecture we support, i386 > was > just taken as the most popular example here. > > I'm posting this here now, because I don't want to upset other people now > that the script logic is changed again. If you rather like the current > "clean" logic instead of my proposal, please tell me. > I leave this discussion opened for several weeks as I currently don't have > much time anyway. If there are no negative comments, the new script will be > committed afterwards. > > Best regards, > > Colin > > > _______________________________________________ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev