This is a suboptimal way of handling it, because it will cause the compiler to instantiate all GUIDs in all compilation units. When linking only one will be selected for the executable, but still it increases the size of all object files. If it is to allow a precompiled header, I suggest adding an additional guid.c file, that only includes the guid headers, not the precompiled header.
Timo Am 24.12.2013 21:58, schrieb [email protected]: > Author: akhaldi > Date: Tue Dec 24 20:58:27 2013 > New Revision: 61381 > > URL: http://svn.reactos.org/svn/reactos?rev=61381&view=rev > Log: > [USBSTOR] > * Define INITGUID in the main header. > CORE-7716 > > Modified: > trunk/reactos/drivers/usb/usbstor/usbstor.c > trunk/reactos/drivers/usb/usbstor/usbstor.h > > Modified: trunk/reactos/drivers/usb/usbstor/usbstor.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/usbstor.c?rev=61381&r1=61380&r2=61381&view=diff > ============================================================================== > --- trunk/reactos/drivers/usb/usbstor/usbstor.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/usb/usbstor/usbstor.c [iso-8859-1] Tue Dec 24 > 20:58:27 2013 > @@ -10,7 +10,6 @@ > > /* INCLUDES > ******************************************************************/ > > -#define INITGUID > #include "usbstor.h" > > #define NDEBUG > > Modified: trunk/reactos/drivers/usb/usbstor/usbstor.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/usbstor.h?rev=61381&r1=61380&r2=61381&view=diff > ============================================================================== > --- trunk/reactos/drivers/usb/usbstor/usbstor.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/usb/usbstor/usbstor.h [iso-8859-1] Tue Dec 24 > 20:58:27 2013 > @@ -1,5 +1,7 @@ > > #pragma once > + > +#define INITGUID > > #include <ntddk.h> > #include <usbdi.h> > > > _______________________________________________ Ros-dev mailing list [email protected] http://www.reactos.org/mailman/listinfo/ros-dev
