Re: [ros-dev] [ros-diffs] [pschweitzer] 65166: [NTFS] Simplify buffer size management in GetNtfsFileRecord(). As tests shown, Windows doesn't care about the real size of the file record and expects the caller to pass the co...

Sat, 01 Nov 2014 03:16:09 -0700 

On 2014-11-01 11:02, [email protected] wrote:
> -    OutputBuffer->FileRecordLength = FileRecord->BytesInUse;
> -    RtlCopyMemory(OutputBuffer->FileRecordBuffer, FileRecord, 
> FileRecord->BytesInUse);
> +    OutputBuffer->FileRecordLength = DeviceExt->NtfsInfo.BytesPerFileRecord;
> +    RtlCopyMemory(OutputBuffer->FileRecordBuffer, FileRecord, 
> DeviceExt->NtfsInfo.BytesPerFileRecord);

Wait, now there's no check against OutputBufferLength at all? It should
at least be
min(DeviceExt->NtfsInfo.BytesPerFileRecord,
    Stack->Parameters.FileSystemControl.OutputBufferLength)
in the memcpy size. Or am I missing something?

_______________________________________________
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Reply via email to