Hi, I completely agree, and that's why I put in comment that INT_MIN stuff.
Hermès -----Message d'origine----- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Neo Love Envoyé : vendredi 3 mars 2017 01:26 À : ReactOS Development List Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 73895: [NTGDI]: Few fixes & hacks for NtGdiGetGlyphIndicesW, see CORE-12825: - (Fix) Check for integer count overflow (per Thomas suggestion), - (Hack#1) Signal the particular calling ca... If 'cwc' is a pointer or anything that would ever become 64 bits in x64 this type of coding needs rewriting using symbolic sizes. (Such as ULONG_PTR(-1) and similar constructs..) On 2017-02-24 20.42, Thomas Faber wrote: > + /* Check for integer overflow */ > + if (cwc & 0x80000000) // (INT_MAX + 1) == INT_MIN L. _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
