[ros-diffs] [akhaldi] 70261: [IPHLPAPI_APITEST] Move icmp tests from winetests to apitests where they belong. By Tim Crawford. ROSTESTS-201

[akhaldi]

Author: akhaldi
Date: Fri Dec  4 10:34:24 2015
New Revision: 70261

URL: http://svn.reactos.org/svn/reactos?rev=70261&view=rev
Log:
[IPHLPAPI_APITEST] Move icmp tests from winetests to apitests where they 
belong. By Tim Crawford. ROSTESTS-201

Added:
    trunk/rostests/apitests/iphlpapi/icmp.c
      - copied, changed from r70260, trunk/rostests/winetests/icmp/icmp.c
Removed:
    trunk/rostests/winetests/icmp/
Modified:
    trunk/rostests/apitests/iphlpapi/CMakeLists.txt
    trunk/rostests/apitests/iphlpapi/testlist.c
    trunk/rostests/winetests/CMakeLists.txt

Modified: trunk/rostests/apitests/iphlpapi/CMakeLists.txt
URL: 
http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/iphlpapi/CMakeLists.txt?rev=70261&r1=70260&r2=70261&view=diff
==============================================================================
--- trunk/rostests/apitests/iphlpapi/CMakeLists.txt     [iso-8859-1] (original)
+++ trunk/rostests/apitests/iphlpapi/CMakeLists.txt     [iso-8859-1] Fri Dec  4 
10:34:24 2015
@@ -1,5 +1,6 @@
 
 list(APPEND SOURCE
+    icmp.c
     SendARP.c
     testlist.c)
 

Copied: trunk/rostests/apitests/iphlpapi/icmp.c (from r70260, 
trunk/rostests/winetests/icmp/icmp.c)
URL: 
http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/iphlpapi/icmp.c?p2=trunk/rostests/apitests/iphlpapi/icmp.c&p1=trunk/rostests/winetests/icmp/icmp.c&r1=70260&r2=70261&rev=70261&view=diff
==============================================================================
--- trunk/rostests/winetests/icmp/icmp.c        [iso-8859-1] (original)
+++ trunk/rostests/apitests/iphlpapi/icmp.c     [iso-8859-1] Fri Dec  4 
10:34:24 2015
@@ -1,5 +1,5 @@
 /*
- * Unit test suite for Icmp.dll functions
+ * Unit test suite for Icmp functions
  *
  * Copyright 2006 Steven Edwards
  *
@@ -17,17 +17,11 @@
  * License along with this library; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
-/*
- * TODO:
- * It seems under Windows XP, 2003 and Vista these functions are not 
implemented
- * in iphlpapi. Move the implementation and tests there.
- */
 
-#include <windows.h>
-#include "wine/test.h"
-
-HANDLE WINAPI IcmpCreateFile(void);
-BOOL WINAPI IcmpCloseHandle(HANDLE handle);
+#include <apitest.h>
+#include <ws2tcpip.h>
+#include <iphlpapi.h>
+#include <icmpapi.h>
 
 HANDLE handle;
 

Modified: trunk/rostests/apitests/iphlpapi/testlist.c
URL: 
http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/iphlpapi/testlist.c?rev=70261&r1=70260&r2=70261&view=diff
==============================================================================
--- trunk/rostests/apitests/iphlpapi/testlist.c [iso-8859-1] (original)
+++ trunk/rostests/apitests/iphlpapi/testlist.c [iso-8859-1] Fri Dec  4 
10:34:24 2015
@@ -3,10 +3,12 @@
 #define STANDALONE
 #include <apitest.h>
 
+extern void func_icmp(void);
 extern void func_SendARP(void);
 
 const struct test winetest_testlist[] =
 {
+    { "icmp",                 func_icmp },
     { "SendARP",              func_SendARP },
 
     { 0, 0 }

Modified: trunk/rostests/winetests/CMakeLists.txt
URL: 
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/CMakeLists.txt?rev=70261&r1=70260&r2=70261&view=diff
==============================================================================
--- trunk/rostests/winetests/CMakeLists.txt     [iso-8859-1] (original)
+++ trunk/rostests/winetests/CMakeLists.txt     [iso-8859-1] Fri Dec  4 
10:34:24 2015
@@ -31,7 +31,6 @@
 add_subdirectory(gdi32)
 add_subdirectory(gdiplus)
 add_subdirectory(hlink)
-add_subdirectory(icmp)
 add_subdirectory(imagehlp)
 add_subdirectory(imm32)
 add_subdirectory(inetcomm)