https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5bb36e92c522bf94b7d399183008ca7d5f9a5356
commit 5bb36e92c522bf94b7d399183008ca7d5f9a5356 Author: Joachim Henze <[email protected]> AuthorDate: Sat Oct 3 16:39:13 2020 +0200 Commit: Joachim Henze <[email protected]> CommitDate: Sat Oct 3 16:39:13 2020 +0200 [WDMAUD.DRV] Revert "Workaround multiple issues with AC97 driver from rapps" This reverts commit 0.4.15-dev-791-g 6d7ebc20481a587bd19e8a8049317113071b0817 It was a workaround just. To bypass sysaudio. It had a very positive effect on our playback performance, but using the different codepaths did also lead to regressions, that I have no idea how to address, therefore I think it's my personal responsibility to revert it. I guess it's better to improve on the code-paths that we intend to use finally, instead of fixing what will be dead paths in the future. The revert will fix: - CORE-17277 crash of dsound:duplex on "GCCLin_x86 on Test VBox" - CORE-17278 crash of dsound:capture on "GCCLin_x86 on Test VBox" - CORE-17285 Realtek HD Audio does no longer work in ReactOS But ofc now we will suffer again from very severe things that the hack could workaround: - CORE-13202 Unhandled exception from wdmaud.drv when recording sound in Scratch 1.4 leads to app-crash - CORE-13488 A deadlock in "DiabloII" character selection screen and "The Lion King II" - CORE-8726/CORE-9986/CORE-16564 AC97 driver from rapps will need reboot-orgies again, does not longer work in the same session that we installed the driver - CORE-9981 "DosBox + Commander Keen6" totally garbled sound output instead of music "ScummVM 2.0 with Monkey Island 2" totally garbled sound output instead of music - the test execution times of "GCCLin_x86 on Test VBox" will almost double --- dll/win32/wdmaud.drv/wdmaud.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dll/win32/wdmaud.drv/wdmaud.c b/dll/win32/wdmaud.drv/wdmaud.c index 45308b3aff2..dfd8ea0361e 100644 --- a/dll/win32/wdmaud.drv/wdmaud.c +++ b/dll/win32/wdmaud.drv/wdmaud.c @@ -18,7 +18,6 @@ #include <debug.h> #include <mmebuddy_debug.h> -#define USE_MMIXER_LIB #ifndef USE_MMIXER_LIB #define FUNC_NAME(x) x##ByLegacy #else
