https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0293d0c59788d397ff4598688f02d54a8a1aea2f
commit 0293d0c59788d397ff4598688f02d54a8a1aea2f
Author: Hermès Bélusca-Maïto <hermes.belusca-ma...@reactos.org>
AuthorDate: Tue Sep 10 15:09:58 2024 +0200
Commit: Hermès Bélusca-Maïto <hermes.belusca-ma...@reactos.org>
CommitDate: Tue Sep 10 15:12:10 2024 +0200
[SHELL32] CDefView.cpp: fix MSVC build warning C5208
"unnamed class used in typedef name cannot declare members other than
non-static data members, member enumerations, or member classes."
Suggestion by Whindmar Saksit.
Use `struct LISTVIEW_SORT_INFO` instead of the typedef, since this
is a structure defined and used only in this file, and we don't use
pointers to it (LPLISTVIEW_SORT_INFO).
---
dll/win32/shell32/CDefView.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dll/win32/shell32/CDefView.cpp b/dll/win32/shell32/CDefView.cpp
index bb3e88239c2..61bc1581234 100644
--- a/dll/win32/shell32/CDefView.cpp
+++ b/dll/win32/shell32/CDefView.cpp
@@ -58,7 +58,7 @@ enum {
};
#undef FCIDM_SHVIEWLAST // Don't use this constant, change
DVIDM_CONTEXTMENU_LAST if you need a new id.
-typedef struct
+struct LISTVIEW_SORT_INFO
{
INT8 Direction;
bool bLoadedFromViewState;
@@ -72,7 +72,7 @@ typedef struct
*(UINT*)this = 0;
ListColumn = UNSPECIFIEDCOLUMN;
}
-} LISTVIEW_SORT_INFO, *LPLISTVIEW_SORT_INFO;
+};
#define SHV_CHANGE_NOTIFY (WM_USER + 0x1111)
#define SHV_UPDATESTATUSBAR (WM_USER + 0x1112)
