https://git.reactos.org/?p=reactos.git;a=commitdiff;h=44bdafa17e2b870c570ea15f3bdb56decfd7aaa5
commit 44bdafa17e2b870c570ea15f3bdb56decfd7aaa5
Author: Thomas Faber <thomas.fa...@reactos.org>
AuthorDate: Sat May 27 22:37:47 2023 -0400
Commit: Timo Kreuzer <timo.kreu...@reactos.org>
CommitDate: Thu Sep 12 17:44:13 2024 +0300
[KMTESTS:SE] Fix failing tests.
---
modules/rostests/kmtests/ntos_se/SeQueryInfoToken.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/modules/rostests/kmtests/ntos_se/SeQueryInfoToken.c
b/modules/rostests/kmtests/ntos_se/SeQueryInfoToken.c
index f58bbc3b17e..950cb78e35c 100644
--- a/modules/rostests/kmtests/ntos_se/SeQueryInfoToken.c
+++ b/modules/rostests/kmtests/ntos_se/SeQueryInfoToken.c
@@ -328,6 +328,10 @@ START_TEST(SeQueryInfoToken)
// Testing SeFreePrivileges //
//----------------------------------------------------------------//
+ // FIXME: KernelMode will automatically get all access granted without
+ // getting Privileges filled in. For UserMode, Privileges will only get
+ // filled if either WRITE_OWNER or ACCESS_SYSTEM_SECURITY is requested
+ // and granted. So this doesn't really test SeFreePrivileges.
Privileges = NULL;
Checker = SeAccessCheck(
AccessState->SecurityDescriptor,
@@ -342,7 +346,7 @@ START_TEST(SeQueryInfoToken)
&Status
);
ok(Checker, "Checker is NULL\n");
- ok((Privileges != NULL), "Privileges is NULL\n");
+ ok(Privileges == NULL, "Privileges is not NULL\n");
if (Privileges)
{
trace("AuxData->PrivilegesUsed->PrivilegeCount = %d ;
Privileges->PrivilegeCount = %d\n",
@@ -390,6 +394,8 @@ START_TEST(SeQueryInfoToken)
// Call SeFreePrivileges again
+ // FIXME: See other SeAccessCheck call above, we're not really testing
+ // SeFreePrivileges here.
Privileges = NULL;
Checker = SeAccessCheck(
AccessState->SecurityDescriptor,
@@ -404,7 +410,7 @@ START_TEST(SeQueryInfoToken)
&Status
);
ok(Checker, "Checker is NULL\n");
- ok((Privileges != NULL), "Privileges is NULL\n");
+ ok(Privileges == NULL, "Privileges is not NULL\n");
if (Privileges)
{
trace("AuxData->PrivilegesUsed->PrivilegeCount = %d ;
Privileges->PrivilegeCount = %d\n",
