On Thursday 16 September 2004 07:36, Matthias Neeracher wrote:
>
> This is, of course, your call to make. I experimented with one design
> which preserved the symbolic
> Qt constants (by writing a lazy wrapper for QColor and an explicit
> initialization function to be called from main),
> but that required small changes in lots of files and colours.cpp itself
> was much uglier.
>
> If I had written the code in question from scratch, my instinct would
> have been to bundle all the colors in a
> singleton struct, but I suppose this design would not fit in at all
> with the current Rosegarden style, from what I can see.
That 2nd way is how I'd like to change this as well. We need to change this
anyway, given that relying on the order of static initialisation is wrong, no
matter if it works currently on Linux.
> I should also point out that the file was already full of ugly magic
> numbers BEFORE I touched it :-)
Yes, for custom colors, but to have those for pre-defined ones is a bit silly.
Plus we have the same problem with accidental names as you pointed out
earlier.
--
Guillaume.
http://www.telegraph-road.org
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
