On Monday 14 November 2005 01:23, Guillaume Laurent wrote:
> On Monday 14 November 2005 00:31, Guillaume Laurent wrote:
> > On Sunday 13 November 2005 22:25, Chris Cannam wrote:
> > > Shame. That doesn't answer the question of why it's so slow when
> > > dragging a selection while scrolling vertically. The slowness seems
> > > proportional to the number of segments visible (rather than the number
> > > being selected),
> >
> > I'll take a look.
>
> OK, I think I know what it is, setting the selection rect causes the model
> to trigger an update. Not a good idea when autoscrolling kicks in. I'll try
> to fix that as soon as possible.
A patch you can try. It improves things a whole lot here (as it should) but I
hesitate to commit it because every time I tried reverting from forced
repaints to scheduled updates, you complained about refresh problems.
Index: compositionview.cpp
===================================================================
RCS file: /cvsroot/rosegarden/gui/compositionview.cpp,v
retrieving revision 1.115
diff -u -b -p -r1.115 compositionview.cpp
--- compositionview.cpp 13 Nov 2005 17:57:34 -0000 1.115
+++ compositionview.cpp 14 Nov 2005 00:28:14 -0000
@@ -1594,8 +1594,8 @@ void CompositionView::slotUpdate()
{
RG_DEBUG << "CompositionView::slotUpdate()\n";
slotAllDrawBuffersNeedRefresh();
- repaintContents(false);
-// updateContents();
+// repaintContents(false);
+ updateContents();
}
void CompositionView::slotUpdate(const QRect& rect)
@@ -1603,11 +1603,11 @@ void CompositionView::slotUpdate(const Q
RG_DEBUG << "CompositionView::slotUpdate() rect " << rect << endl;
slotAllDrawBuffersNeedRefresh();
if (rect.isValid()) {
- repaintContents(rect, false);
-// updateContents(rect);
+// repaintContents(rect, false);
+ updateContents(rect);
} else
- repaintContents(false);
-// updateContents();
+// repaintContents(false);
+ updateContents();
}
void CompositionView::slotRefreshColourCache()
--
Guillaume.
http://www.telegraph-road.org
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
