On Sat, 2005-12-03 at 09:44 +0000, Chris Cannam wrote:
> On Saturday 03 Dec 2005 07:48, Stephen Torri wrote:
> > - usability (e.g. how easy is it to add a new chord)
> 
> Before I get too involved in details, can you explain the intended 
> general workflow of the dialogs?

User story:

A user wants to add a new guitar chord diagram, called a fretboard, to
their sheet music. They open the notation editor and press F9. This puts
them into the Guitar Addition mode if you would call it that. When they
click on the sheet above the measure they want the fretboard to appear
the GuitarTabSelectorDialog will be displayed. If the chord they want
exists in the present ChordMap then they can select, click on Ok and the
fretboard will be displayed. If not then they can click on Create and
the GuitarChordEditor will be displayed. Once they have created the
chord and click Ok the changed chord map is saved to disk and the chord
is available for use in the GuitarTabSelectorDialog. At that point they
can insert it with the same method had it already existed.

> Some questions, just so I can judge what's what:
> 
> In the selector dialog, you can select a chord from the boxes at the 
> top, and that chord is displayed.  There is also an Aliases box which 
> contains editable text.  What is editing that box expected to do?

That should not be editable. That for pointing that out. Its suppose to
alert the user that a chord might have more than one name. (Bug noted)

> If you click Modify or Create in that dialog, the chord editor dialog 
> appears.  This dialog allows you to modify a chord, but it also 
> contains an area in which you can specify a chord name and aliases.  If 
> you modify an existing chord, then change the name and click OK, is it 
> expected to save the modified version under that new name?  (What if 
> there is another chord already existing with that new name?)

The ability to rename a chord, that is change the data in the Chord tab,
is something that I plan on working on. So its on my todo list.

At present I spot duplicates which I alert to the user via the
std::cout. Not ideal but at this time I don't know how to present a
message to the user any other way. After alerting the user the function
used to insert the chord will abort and nothing will happen.

> If editing this chord name is a way of selecting where to save the chord 
> to, that would imply that there's no way from within the editor dialog 
> to load up a different, existing chord for editing, right?  (You'd have 
> to close the dialog, select the chord in the selector dialog, and then 
> click Modify again.)

Let me paraphrase what I think you are asking. In a scenario where I
want to edit one chord my present design works fine. Now if a user wants
to edit more than one chord then yes they must edit their present chord,
click ok, select the other chord and select modify.

The point of this first draft was to keep it simple. At present the best
method to modify things is to open the individual XML files and edit
them. The down side to this method is that any duplicates will not be
known until run-time.

Stephen

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to