On Tuesday 20 December 2005 00:55, Chris Cannam wrote:
> On Monday 19 Dec 2005 20:25, Chris Cannam wrote:
> > Next things:
> >
> >  -- The MIDI record segment doesn't appear until the first event
> > arrives (but updates smoothly after that).  Fix.
>
> Not fixed.  Attached is a patch I previously mentioned, that does some
> of this (i.e. it does actually make the MIDI record segment appear as
> soon as you start recording).  But it causes some pretty insidious
> crashes.  See about half way through my email of 22:46 this evening for
> more about this one.  I'm including the patch anyway because it might
> be a good starting point (or hint of what not to do).

valgrind found the problem, it was a double deletion caused by the fact that 
CompositionModelImpl::segmentRemoved() wasn't handling the case of the 
segment being a recording one, hence also needing to be removed from 
m_recordingSegments.

I've committed your patch along with a fix.

-- 
Guillaume.
http://www.telegraph-road.org


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to