On Wed, Nov 5, 2008 at 1:16 PM, Henrik Andersson <[EMAIL PROTECTED]> wrote: > I managed to create the patch, and ill post it here and the forwarded mail > contains the information on what the patch does..
Thanks Henrik. I've committed the patch to trunk and given you Subversion commit access as well. It certainly looks good so far, but I have a few comments: * It really needs better feedback while dragging. The status bar update is good, but I don't think it's enough. It would be great if the note colours updated as you dragged (changing temporarily from the blue for selection back to the velocity colour), and if the bars on the velocity ruler also updated while you dragged. I realise that this is not likely to be so simple (we would need to ensure that the command that made the final change was still only pushed to the command history once), but it's certainly worth investigating -- can you see whether you can see an easy way to do either or both of these? * It needs a better icon. Anyone? * The new tool did not seem to have been added to matrix.rc or anywhere else by your patch (?) -- so I added it. I hope I put it in the places you were expecting to find it. * We need to remove the [ ] controls from the ruler -- as the comments in the tracker note, they never did quite what you expect and hopefully should not be necessary with these changes (is that right?). Chris ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
