On Wed, 19 Jun 2019, at 14:06, Ted Felix wrote: > Since I'm making changes to FastVector, it sure would be nice to be > able to test it. It looks like its intent is to provide some sort of > performance improvement. So, I assume someone (Chris) at some point had > a test suite to confirm actual performance improvements. It would be a > start anyway. Nothing jumps out at me in the "test" directory. > > Do we have anything for testing FastVector?
The short answer is no, and the sanest thing may be to remove the class entirely. This class dates (in one form or another) to a time before widespread use of the STL, so it would likely have been the only vector class in early projects that used it. It also differs from std::vector in that it expects you to be inserting in the middle, and so it was very much faster for some use cases. It would certainly have been measured at the time. I have no idea whether any of those tests survived I bet there is no worthwhile performance difference now, within the limited extent to which the class is used in Rosegarden... so any time spent writing tests for it is almost certainly better spent writing tests for the weird Composition::ReferenceSegment thing that inherits (!) from it, then rewriting that so as to use normal containers like a sensible class would, and dropping FastVector. Chris _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
