On 1/8/22 7:51 AM, David Faure wrote:
However I found the following issues, can you let me know if you want to fix them or if I should look into them myself (and in that case maybe you have hints about where I should look)?
If you have time, that would be great. Otherwise I think we'll open some bug reports and Philip will likely get to them shortly.
1) In the Notation editor, press F3, move the mouse around on the segment (which shows a temporary green note), press F2 => the green note stays visible at the last position. Clearly it should be hidden at that point.
Confirmed in 21.12. And it goes away when the mouse leaves the frame. So somebody is still tracking it.
Hints? The Notation* classes are probably the key here. In particular one of NotationView or NotationScene I think coordinates the tools. Then NotationTool and NotationToolBox might also be involved.
2) From F3/F8 mode, pressing Esc appears to go back to select mode like F2 would do (the mouse cursor changes, clicking works like in select mode), but the selected toolbar action still says F3/F8 mode rather than select mode. This made me think Esc didn't work, for a long time...
Confirmed in 21.12. Again the Notation* and NotationTool* classes are probably involved here.
3) I can't open two rosegarden files at the same time, for comparison. If I open a second file in an existing process, it replaces the open one. If I try to launch a second rosegarden instance, it fails to start with: Cannot connect to server socket err = No such file or directory exec of JACK server (command = "/usr/bin/jackd") failed: No such file or directory
I have many instances of rg up all the time without any modifications to the code. Have you tried disabling the following preference:
Edit > Preferences... > Audio > Start JACK Automatically That might fix this. I always have that unchecked.
4) After making a change in the notation editor, I press Ctrl+S to save. This appears to work, the "*" character disappears from the titlebar of the *main window*, but not from the titlebar of the notation editor window. I have to press Ctrl+S *again*, and then the "*" goes away. Minor, but not reassuring if one uses the notation editor fullscreen :)
I've noticed that "*" is indeed a touch finicky in several situations. Also it comes on for what appears to be no reason and sometimes doesn't appear at all. This is part of the restructuring I was trying to do to simplify some of the unnecessarily complicated change notification mechanisms throughout the code. I think it's probably worth a look for this particular case, but don't be surprised if it's a bit of a mess in there.
Hints? RosegardenDocument is the location of the main change notification mechanism. slotDocumentModified(), documentModified(), clearModifiedStatus(), etc... Anything with "modified" in the name is probably involved. I'm not sure how the notation view finds out about document changes, but it should connect for the documentModified() signal, or something similar. It's also possible that on the first save, something silly happens that modifies the document and causes the star to come back on. I would look for things like this.
Ted. _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
