Thanks, David. I've committed and pushed. Also pushed the switch to
QString::endsWith().
Ted.
On 2/17/22 2:47 AM, David Faure wrote:
On jeudi 17 février 2022 07:36:10 CET mark_at_yahoo via Rosegarden-devel
wrote:
Will do. I had temporarily commented out the code in my working tree
despite being concerned about what the rg_OPTIONAL_LIB_DIRS are used
for. But if you're okay with ignoring them for cmake < 3.13.0 builds,
let's go for it.
It's used to find libjack when linking to it.
But things aren't usually done this way in CMake, which is why
target_link_directories didn't exist until recently. The "right" way to use
pkgconfig is to follow it with a find_library call in order to resolve "lib
name jack in /usr/lib64" (as returned by pkgconfig) into a full path (/usr/
lib64/libjack.so) to link against.
This is done in the attached patch. I have to go see a customer now, feel free
to make a merge request with this patch if you like it.
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
