On 2/18/22 22:14, mark_at_yahoo via Rosegarden-devel wrote:
On 2/18/22 11:54 AM, Philip Leishman wrote:
On 2/18/22 19:18, mark_at_yahoo via Rosegarden-devel wrote:
The highlight mode menu was in 21.12 !
Make sure you are using the git repository. We used to be on SVN but
switched to git some time back. The latest git will also have the
highlight menu.
It's a complete mystery, Philip. :(
Yes, I'm using git. Just to double-check, I did a fresh clone of the
SourceForge repository and built 21.12 -- and got the same results (no
hilight menu). I also built master and again no joy, although note I
had to make a small patch for my Qt5 5.9.7, as per
https://sourceforge.net/p/rosegarden/mailman/rosegarden-devel/thread/88726f65-8f9f-0b19-50b0-a1a437a8deea%40tedfelix.com/#msg37612478
and:
Activity for Rosegarden:
1 day ago
Ted Felix Ted Felix committed [e62e6e]
Use QString::endsWith(), even better
(It also needs a bunch of startsWith() calls. I'll send Ted a patch.
Not his fault because the bug doesn't show up with later Qt5 versions
like he uses.)
Details of my builds below in case you're interested. I'll keep
hacking on it but I'm clueless for right now.
May I suggest you create a new feature ticket for this. We can continue
the discussion in the ticket.
Excellent suggestion. I hadn't done so because SourceForge was telling
me I didn't have permissions to create tickets (my bad, I wasn't
logged in) and also I'm new here and don't know your policies (some
projects like to have mailing list discussions before a user files a
ticket).
I'll create one, but I'm including my build logs here because they're
probably not relevant to the ticket. Again, thanks for your help, and
if you have the time and see anything I've done wrong below, please
tell me.
Build log:
$ git clone https://git.code.sf.net/p/rosegarden/git rosegarden-git
Cloning into 'rosegarden-git'...
remote: Enumerating objects: 159806, done.
remote: Counting objects: 100% (159806/159806), done.
remote: Compressing objects: 100% (26792/26792), done.
remote: Total 159806 (delta 136140), reused 155823 (delta 132695)
Receiving objects: 100% (159806/159806), 138.48 MiB | 43.23 MiB/s, done.
Resolving deltas: 100% (136140/136140), done.
$ ls
rosegarden-git/
$ cd rosegarden-git
$ git checkout 21.12
Note: switching to '21.12'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to
false
HEAD is now at 5f68aeae6 Updates for version 21.12
$ mkdir build
$ cd build
$ cmake ..
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
-- Checking for module 'alsa>=0.9'
-- Found alsa, version 1.1.5
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11")
-- Found X11: /usr/include
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so
-- Looking for XOpenDisplay in
/usr/lib64/libX11.so;/usr/lib64/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Checking for module 'liblo>=0.7'
-- Found liblo, version 0.28
-- Checking for module 'lrdf>=0.2'
-- Found lrdf, version 0.5.0
-- Checking for module 'fftw3f>=3.0.0'
-- Found fftw3f, version 3.3.6-pl2
-- Checking for module 'samplerate>=0.1.2'
-- Found samplerate, version 0.1.9
-- Checking for module 'sndfile>=1.0.16'
-- Found sndfile, version 1.0.28
-- Checking for module 'jack'
-- Found jack, version 1.9.12
-- The following features have been enabled:
* ALSA, Alsa library (Advanced Linux Sound Architecture), used for
MIDI support
* SNDFILE, Better support for WAV files
* JACK, Library for accessing the JACK server (http://jackaudio.org).
* LIRCCLIENT, The LIRC client library, for remote control support
-- The following REQUIRED packages have been found:
* Qt5Core
* Qt5Gui
* Qt5Widgets
* Qt5Xml
* Qt5Network
* Qt5PrintSupport
* Qt5Test
* Qt5 (required version >= 5.1.0)
* ZLIB
* PkgConfig
* X11
-- Not building unit tests, using a static library for rosegarden
-- Found SharedMimeInfo: /usr/bin/update-mime-database (found suitable
version "1.9", minimum required is "0.50")
-- Configuring done
-- Generating done
-- Build files have been written to:
/usr/local/x/rosegarden/unbacked/21.12/rosegarden-git/build
$ make -j 9
...
[100%] Linking CXX executable ../rosegarden
[100%] Built target rosegarden
$ ./rosegarden --version
Rosegarden version: 21.12 ("Cloud Nine")
Build key: d9b8dbc6b5 (21.12)
Built against Qt version: 5.9.7
$ ./rosegarden
<same as previous build: no Matrix Editor -> View v hilight menu>
$ git status
HEAD detached at 21.12
nothing to commit, working tree clean
$ git checkout master
Previous HEAD position was 5f68aeae6 Updates for version 21.12
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
$ make clean
$ cmake ..
$ cmake ..
-- Checking for module 'jack'
-- Found jack, version 1.9.12
-- The following features have been enabled:
* ALSA, Alsa library (Advanced Linux Sound Architecture), used for
MIDI support
* SNDFILE, Better support for WAV files
* JACK, Library for accessing the JACK server (http://jackaudio.org).
* LIRCCLIENT, The LIRC client library, for remote control support
-- The following REQUIRED packages have been found:
* Qt5Core
* Qt5Gui
* Qt5Widgets
* Qt5Xml
* Qt5Network
* Qt5PrintSupport
* Qt5Test
* Qt5 (required version >= 5.1.0)
* ZLIB
* PkgConfig
* X11
-- Not building unit tests, using a static library for rosegarden
-- Configuring done
-- Generating done
-- Build files have been written to:
/usr/local/x/rosegarden/unbacked/21.12/rosegarden-git/build
$ emacsclient ../src/sound/AudioFileManager.cpp
$ git --no-pager diff -w ../src/sound/AudioFileManager.cpp
diff --git a/src/sound/AudioFileManager.cpp
b/src/sound/AudioFileManager.cpp
index 57c55d1a0..b1c63922d 100644
--- a/src/sound/AudioFileManager.cpp
+++ b/src/sound/AudioFileManager.cpp
@@ -335,9 +335,9 @@ AudioFileManager::setRelativeAudioPath(
newRelativePath = ".";
// If the path doesn't start with "~", "/", or "."...
- if (newRelativePath.front() != '/' &&
- newRelativePath.front() != '~' &&
- newRelativePath.front() != '.') {
+ if (!newRelativePath.startsWith('/') &&
+ !newRelativePath.startsWith('~') &&
+ !newRelativePath.startsWith('.')) {
// Use the document path.
newRelativePath = "./" + newRelativePath;
}
$ make -j 9
...
[100%] Linking CXX executable ../rosegarden
[100%] Built target rosegarden
$ ./rosegarden --version
Rosegarden version: 22.06 ("Distant Drums")
Build key: e56bcd8f3c (21.12-165-g191366409*)
Built against Qt version: 5.9.7
$ ./rosegarden
<same as 21.12 build: no Matrix Editor -> View v hilight menu>
Very mysterious !!!
You should see in the code:
in data/rc/matrix.rc - the definition of the menu:
<Menu name="Highlight">
<text>&Highlight</text>
<Action name="highlight_black_notes" text="Highlight black notes"
checked="false" />
<Action name="highlight_triads" text="Highlight triads"
checked="false" />
</Menu>
and in src/gui/editors/matrix/MatrixView.cpp - the creation of the actions:
createAction("show_note_names", SLOT(slotShowNames()));
createAction("highlight_black_notes", SLOT(slotHighlight()));
createAction("highlight_triads", SLOT(slotHighlight()));
// add the highlight actions to an ActionGroup
QActionGroup *ag = new QActionGroup(this);
ag->addAction(findAction("highlight_black_notes"));
ag->addAction(findAction("highlight_triads"));
The only thing a bit unusual is the QActionGroup.
Another place this is used is in the notation editor - Can you see the
note font and size menu items at the top of the view menu ?
Something to do with Qt version: 5.9.7 ???
Very strange
Philip
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to
unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
