Henrik Grubbström <[EMAIL PROTECTED]> wrote:

> On Mon, 11 Aug 2008, Stephen R. van den Berg wrote:
>
>> I identified the culprit (did a bi-sect using git), it is:
>>
>> commit 125fdf82c3df848ac8065cb04592badb62262b6d
>> Author: Henrik Grubbstr<C3><B6>m (Grubba) <[EMAIL PROTECTED]>
>> Date:   Tue Jun 24 20:14:10 2008 +0000
>>
>>    Now uses Mapping.ShadowedMapping to implement all_constants().
>>
>> Any idea where the fix goes?
>
> Most likely into the codec that Roxen uses.

Note that 5.0 no longer do any dumping at all. I looked a bit at
fixing it with 7.7, but the whole dumping bit is Kludge City++, so I
decided to just cut it out and spend the time on things that matters
instead. Loading time is no longer a significant issue, I think.

If it is to be fixed, I think it needs a major cleanup. Roxen
shouldn't use its own codec at all, since the one in Pike nowadays is
much better. If Roxen really needs its own codec, it should at least
build on the one in Pike. And all those dumping constants should be
solved in a less ad-hoc way.

Reply via email to