"Stuart Roll" <[EMAIL PROTECTED]> writes:

> Dan -
>
> Thanks for the quick response!  Maybe someday I'll get a few minutes and
> work with the source tree and submit some code.  Until then, thanks for
> helping me out.
>
> There was a related change checked in right afterward that included this
> snippet:
>
>   -    private static final String DEFAULT_PARSER
> = "uk.co.wilson.xml.MinML";
>   +    private static final String DEFAULT_PARSER = MinML.class.getName();
>
> While I generally applaud the avoidance of quoted strings like this, in
> this case the old way is preferred.  This change which asks the MinML class
> for its name requires that the MinML class always be bundled with the
> XML-RPC classes.

The standard distribution from xml.apache.org does always bundle MinML
in the XML-RPC JAR file, as MinML is the default parser and is assumed
to always be available.

> I suspect this is an unintended consequence of the update.  As it
> turns out, since we aren't using that parser in our app we don't
> include it in our JAR file.

Hmm...you must be doing a custom build.  Since MinML is expected to
always be in the distribution, I'm thinking that your custom build
should apply the small patch necessary to set the default parser as
desired for your custom packaging.

dlr@despot:xml-rpc$ jar tvf bin/xmlrpc-1.0rc2-dev.jar | grep MinML
 10401 Wed Feb 20 12:22:56 PST 2002 uk/co/wilson/xml/MinML.class
  1114 Wed Feb 20 12:22:56 PST 2002 uk/co/wilson/xml/MinML$1.class
  2820 Wed Feb 20 12:22:56 PST 2002 uk/co/wilson/xml/MinML$MinMLBuffer.class

Note that MinML is _tiny_ (less thank 15kB!), so bundling it is not a
big deal.  The exception to this is of course your applet-based
deployment, but you still need a parser and I don't know of a more
minimal implementation than MinML.  If you're not bundling MinML,
where are you getting your parser?

> Can you please change this back (with a comment explaining the situation)
> or, alternatively, state formally that it is a new *requirement* that MinML
> be bundled?  I would prefer to leave them unbundled but I will accept your
> decision.

The default source package expects MinML to be bundled.  A pluggable
parser factory would obviate this requirement, but until someone
donates one (hint hint nudge nudge), this is how things are.


                             Thanks, Dan

Reply via email to