I'm not a committer, but I could undertake the conversion to the Jakarta
commons logging package, if no one else has already embarked on it.
I think it would primarily involve the simple but tedious process of
replacing:
if (XmlRpc.debug)
{
System.out.println("a message");
}
With:
// get the logger for the class once
private static final Log LOGGER =
LogFactory.getLog(ThisClass.class);
...
// log the message
LOGGER.debug("a message");
It would also probably be nice to leave XmlRpc.setDebug() as a deprecated
method that configures the logging package to print messages on System.out.
--Ed Tellman
-----Original Message-----
From: Ryan Hoegg [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, December 03, 2002 8:16 PM
To: [EMAIL PROTECTED]
Subject: Re: Internal logging API
Daniel Rall wrote:
>Ryan, I've been wanting more elegant handling logging since I started
>working with the package. Rather than make a little tweak here and a
>little tweak there, I think it's time for a more whole-sale approach.
>What's the minimum number of class we'd have to include to make use of
>Jakarta Commons Logging?
>
>
http://jakarta.apache.org/commons/logging/api/org/apache/commons/logging/pac
kage-summary.html
Ryan's Summary:
Looks like we need to import org.apache.commons.logging.Log and
org.apache.commons.logging.LogFactory. With no further configuration,
log messages now go to:
- Log4J if it is found in the classpath
- a java.util.logging.Logger if running on a JDK >= 1.4
- oblivion otherwise
This can be further configured with a system property, a
META-INF/services/org.apache.commons.logging.LogFactory file, or a
commons-logging.properties file.
Since we don't have multiple inheritance, should we stick this stuff in
a utility class or on the XmlRpc base class?
--
Ryan Hoegg
ISIS Networks
http://www.isisnetworks.net
--------------------
This message (including any attachments) may contain confidential
information intended for a specific individual and purpose. If you are not
the intended recipient, delete this message. If you are not the intended
recipient, disclosing, copying, distributing, or taking any action based on
this message is strictly prohibited.
