RPM CVS Repository, Ticket Change Notification http://rpm5.org/cvs ____________________________________________________________________________
Ticket: #17 URL: http://rpm5.org/cvs/tktview?tn=17 Created: 2007-07-01 20:01:16 Creator: rse Contact: - Title: Cleanup pre-processor usage: "#if HAVE_" should be "#f [...] Type: Technology Version: - Subsystem: RPM Severity: 3 Priority: 3 Updated: 2007-07-01 20:01:16 Status: New Assigned: rse ____________________________________________________________________________ Description: RPM has dozens of "#if HAVE_XXXX_H" usages in the code. HAVE_XXXX_H are Autoconf defines and those are either defined or not defined. Although they are 1 in case they are defined, they are _undefined_ else (not 0). So they should not be used in value comparisons. Instead one should use defined(HAVE_XXXX_H) or !defined(HAVE_XXXX_H) only. ______________________________________________________________________ RPM Package Manager http://rpm5.org CVS Sources Repository rpm-cvs@rpm5.org
