RPM Package Manager, CVS Repository
  http://rpm5.org/cvs/
  ____________________________________________________________________________

  Server: rpm5.org                         Name:   Jeff Johnson
  Root:   /v/rpm/cvs                       Email:  j...@rpm5.org
  Module: rpm                              Date:   28-Jun-2013 18:25:47
  Branch: rpm-5_4                          Handle: 2013062816254700

  Modified files:           (Branch: rpm-5_4)
    rpm/lib                 psm.c

  Log:
    - coverity #1035878

  Summary:
    Revision    Changes     Path
    2.399.2.9   +4  -1      rpm/lib/psm.c
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: rpm/lib/psm.c
  ============================================================================
  $ cvs diff -u -r2.399.2.8 -r2.399.2.9 psm.c
  --- rpm/lib/psm.c     26 Jun 2013 17:36:10 -0000      2.399.2.8
  +++ rpm/lib/psm.c     28 Jun 2013 16:25:47 -0000      2.399.2.9
  @@ -2503,19 +2503,22 @@
            /* Write the lead section into the package. */
            {   static const char item[] = "Lead";
                const char * NEVR = rpmteNEVR(psm->te);
  +             const char * msg = xstrdup(NEVR); /* XXX passed to wrLead() */
                size_t nb = rpmpkgSizeof(item, NULL);
        
                if (nb == 0)
                    rc = RPMRC_FAIL;
                else {
                    void * l = memset(alloca(nb), 0, nb);
  -                 rc = rpmpkgWrite(item, psm->fd, l, &NEVR);
  +                 rc = rpmpkgWrite(item, psm->fd, l, &msg);
                }
                if (rc != RPMRC_OK) {
                    rpmlog(RPMLOG_ERR, _("Unable to write package: %s\n"),
                                Fstrerror(psm->fd));
  +                 msg = _free(msg);
                    break;
                }
  +             msg = _free(msg);
            }
   
            /* Write the signature section into the package. */
  @@ .
______________________________________________________________________
RPM Package Manager                                    http://rpm5.org
CVS Sources Repository                                rpm-cvs@rpm5.org

Reply via email to