One more anomaly noted with
cd tests && make clean check
(Note: The tests are still somewhat raw and peculier to my environment.
OTOH, designing a unit test suite for rpm ain't exactly easy ...)
Here's the flaw (from the edos-test*.src.rpm build):
...
re --nodeps edos-test-*.src.rpm
(cd edos-test && /X/src/wdj/rpm --macros /X/src/wdj/macros:/X/src/wdj/
tests/macros -q --specfile edos-test.spec && /X/src/wdj/rpm --macros /
X/src/wdj/macros:/X/src/wdj/tests/macros -q --specsrpm edos-test.spec
&& /X/src/wdj/rpm --macros /X/src/wdj/macros:/X/src/wdj/tests/macros -
q --specfile --specedit edos-test.spec && /X/src/wdj/rpm --macros /X/
src/wdj/macros:/X/src/wdj/tests/macros -bb --nodeps edos-test.spec)
> /dev/null
/usr/lib/rpm/check-files: line 11: cd: /X/src/wdj/tests/tmp//edos-
test-root: No such file or directory
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^^^^^^
/X/src/wdj/rpm --macros /X/src/wdj/macros:/X/src/wdj/tests/macros -i
--nosignature --nodeps probes-test-*.src.rpm
...
Note that the edos-test package has identically named subpkgs with
different versions.
G'nite!
73 de Jeff
On Jul 7, 2008, at 12:11 AM, Alexey Tourbin wrote:
RPM Package Manager, CVS Repository
http://rpm5.org/cvs/
______________________________________________________________________
______
Server: rpm5.org Name: Alexey Tourbin
Root: /v/rpm/cvs Email: [EMAIL PROTECTED]
Module: rpm Date: 07-Jul-2008
06:11:16
Branch: HEAD Handle: 2008070704111600
Modified files:
rpm/build files.c
Log:
genCpioListAndHeader: changed fi->fnlen calculation from
fileURL back
to diskURL, should fix segfault
Summary:
Revision Changes Path
1.337 +2 -1 rpm/build/files.c
______________________________________________________________________
______
patch -p0 <<'@@ .'
Index: rpm/build/files.c
======================================================================
======
$ cvs diff -u -r1.336 -r1.337 files.c
--- rpm/build/files.c 6 Jul 2008 04:24:42 -0000 1.336
+++ rpm/build/files.c 7 Jul 2008 04:11:16 -0000 1.337
@@ -1667,7 +1667,8 @@
}
{
- size_t fnlen = strlen(flp->fileURL);
+ /* this fi uses diskURL (with buildroot), not fileURL */
+ size_t fnlen = strlen(flp->diskURL);
if (fnlen > fi->fnlen) {
/* fnlen-sized buffer must not be allocated yet */
assert(fi->fn == NULL);
@@ .
______________________________________________________________________
RPM Package Manager http://rpm5.org
CVS Sources Repository [EMAIL PROTECTED]
______________________________________________________________________
RPM Package Manager http://rpm5.org
Developer Communication List [email protected]
