This change "works" iff *.la files are present to hint
additional libraries. E.g. -lrpmio needs -lrpmmisc
whether it as expressed explicitly (as before) or implictly (
what is likely happening after your patch is applied).

As long as rpm AutoFu has building without *.la as an
option, then all libraries need to be listed in multiple
places Just In Case.

Yes a PITA, I don't disagree.

hth

73 de Jeff

On Dec 23, 2008, at 5:11 PM, Per Øyvind Karlsen wrote:

  RPM Package Manager, CVS Repository
  http://rpm5.org/cvs/
______________________________________________________________________ ______

  Server: rpm5.org                         Name:   Per Øyvind Karlsen
  Root:   /v/rpm/cvs                       Email:  pkarl...@rpm5.org
Module: rpm Date: 23-Dec-2008 23:11:24
  Branch: HEAD                             Handle: 2008122322112400

  Modified files:
    rpm/perl                Makefile.PL.in

  Log:
    don't link against more libraries than necessary

  Summary:
    Revision    Changes     Path
    1.22        +2  -2      rpm/perl/Makefile.PL.in
______________________________________________________________________ ______

  patch -p0 <<'@@ .'
  Index: rpm/perl/Makefile.PL.in
====================================================================== ======
  $ cvs diff -u -r1.21 -r1.22 Makefile.PL.in
  --- rpm/perl/Makefile.PL.in   5 Dec 2008 05:27:48 -0000       1.21
  +++ rpm/perl/Makefile.PL.in   23 Dec 2008 22:11:24 -0000      1.22
  @@ -4,10 +4,10 @@
   # See lib/ExtUtils/MakeMaker.pm for details of how to influence
   # the contents of the Makefile that is written.

  -my @libdir = qw(. build lib popt rpmdb rpmio misc rpmconstant);
  +my @libdir = qw(. build lib rpmdb rpmio rpmconstant);

   my @ldaddp = map { '-...@top_builddir@/' . $_ . '/.libs' } @libdir;
-my @ldadd = map { '-l' . $_ } qw(rpmmisc rpmio rpmbuild rpm popt rpmdb rpmconstant);
  +my @ldadd = map { '-l' . $_ } qw(rpmbuild rpmconstant);

   my @cppflags = qw(
       -...@srcdir@
  @@ .
______________________________________________________________________
RPM Package Manager                                    http://rpm5.org
CVS Sources Repository                                rpm-...@rpm5.org

______________________________________________________________________
RPM Package Manager                                    http://rpm5.org
Developer Communication List                        rpm-devel@rpm5.org

Reply via email to