2008/12/23 Jeff Johnson <n3...@mac.com> > > On Dec 23, 2008, at 4:57 PM, Jeff Johnson wrote: > > This patch isn't needed. >> >> system.h will include "config.h" if -DHAVE_CONFIG_H is defined >> in CFLAGS, which is done throughout rpm. >> >> And RPM_VENDOR_FOO is passed through CFLAGS, not config.h, >> simpilarly to -DHAVE_CONFIG_H. >> >> > If you __DO__ insist on RPM_VENDOR_MANDRIVA > in config.h rather than CFLAGS et al, then the right fix is > > #include "system.h" > > #if defined(RPM_VENDOR_MANDRIVA) > Yes, but then some stuff would be compiled into filetriggers.o.
> > > consistent with every other file compiled in rpm. > > Slightly worse (but acceptable) is > > #if defined(HAVE_CONFIG_H > #include "config.h" > #endif > > #if defined(RPM_VENDOR_MANDRIVA) > I'll go with this then. :)
