On Fri, Feb 26, 2010 at 6:31 PM, Jeff Johnson <n3...@mac.com> wrote: > The real flaw here is that running "cp -pr ..." > is not the right way to copy files marked %doc. > > There's all sorts of b0rkage in rpmbuild with other file > attributes like %attr and %verify and ... that > simply doesn't scope over %doc files moved with "cp -pr ...". > > (aside) > The preliminaries to "fix" scoping of file attributes over %doc > are underway, and (likely obscurely) staged in tools/cp.c. What > is needed is a internal sparse file tree copy (like "cp -pr ...") > to move files/dirs marked with %doc from %builddir to %buildroot. Also > note that there's another usage case for the deep > file tree copy, permitting replacing a directory > with a symlink, essentially a find -xdev traverse. > > The other flaw, with the ever increasing thundering > herd of possible %docdir directories leads to an > ever increasing __COMPILED IN__ set of directory > paths. The enum of potential %docdir automagic directories > needs to be factored out of code into configuration. > > But your patch is neither better or worse than what RPM has always > done with %doc. > > Do you prefer that I undo the patch ? Or I leave as is pending for the new implementation ?
Thanks 73 de Jeff > > > On Feb 26, 2010, at 12:11 PM, Pinto Elia wrote: > > RPM Package Manager, CVS Repository >> http://rpm5.org/cvs/ >> >> ____________________________________________________________________________ >> >> Server: rpm5.org Name: Pinto Elia >> Root: /v/rpm/cvs Email: devzero2...@rpm5.org >> Module: rpm Date: 26-Feb-2010 18:11:51 >> Branch: HEAD Handle: 2010022617115000 >> >> Modified files: >> rpm CHANGES >> >> Log: >> forget to update CHANGES with the crazy idea >> >> Summary: >> Revision Changes Path >> 1.3274 +2 -0 rpm/CHANGES >> >> ____________________________________________________________________________ >> >> patch -p0 <<'@@ .' >> Index: rpm/CHANGES >> >> ============================================================================ >> $ cvs diff -u -r1.3273 -r1.3274 CHANGES >> --- rpm/CHANGES 21 Feb 2010 20:52:34 -0000 1.3273 >> +++ rpm/CHANGES 26 Feb 2010 17:11:50 -0000 1.3274 >> @@ -1,5 +1,7 @@ >> >> 5.2b1 -> 5.3a1 >> + - devzero2000: use "find" and "mv" if useful instead of "cp -pr" for >> %doc expansion >> + for preventing arg list too long message >> - rpm.org: swipe Tarjan's loopy scissors for hacking. >> - jbj: rpmts: add pluggable check/order/run method vectors. >> - jbj: hkp: add keys.rpm5.org as the default pubkey server. >> @@ . >> ______________________________________________________________________ >> RPM Package Manager http://rpm5.org >> CVS Sources Repository rpm-...@rpm5.org >> > > ______________________________________________________________________ > RPM Package Manager http://rpm5.org > Developer Communication List rpm-devel@rpm5.org >
