Could you put this under a
#ifdef RPM_VENDOR_MANDRIVA
please?
There's a far far deeper issue here, related to whether _ALL_
rpm queries should explicitly indicate NOTFOUND (like "(none)")
or whether "best effort" as in implictly assuming that
anything not reported can be assumed to not exist, that needs
to be soretd through.
In 1998, when RPM from the CLI was the only means to install
packages, it was _ABSOLUTELY_ necessary to supply additional
explicit hints on stdout/stderr (yet another related issue related to less/more
piping)
like "(none)".
The answer these days is much less clear:
All explicit markers like "(none)" in output queries used
for other purposes MUST be filtered.
And finally there's the additional design flaw (specific to Mandriva) or
Provides: /path/to/file
The proper index is Basenames/Filepaths, not Providename, for all tokens that
start with '/'. Its bad craziness to just splatter database entries into
multiple indices because multiple indices must _ALWAYS_ be searched
Just In Case.
The above is the reasoning for the request to add
#ifdef RPM_VENDOR_MANDRIVA
which, because of the Mandriva packaging choice to use
Provides: /path/to/file
to minimize the createrepo-like metadata spewage used by Mandriva, is
_ABSOLUTELY_ the correct fix.
But only for Mandriva.
73 de Jeff
On Nov 1, 2010, at 3:48 PM, Per Øyvind Karlsen wrote:
> RPM Package Manager, CVS Repository
> http://rpm5.org/cvs/
> ____________________________________________________________________________
>
> Server: rpm5.org Name: Per Øyvind Karlsen
> Root: /v/rpm/cvs Email: pkarl...@rpm5.org
> Module: rpm Date: 01-Nov-2010 20:48:26
> Branch: HEAD Handle: 2010110119482500
>
> Modified files:
> rpm CHANGES
> rpm/rpmdb rpmdb.c
>
> Log:
> fix issue with 'rpm -qf' on unowned unowned file not being reported.
> (launchpad #669130)
>
> Summary:
> Revision Changes Path
> 1.3488 +2 -0 rpm/CHANGES
> 1.390 +1 -0 rpm/rpmdb/rpmdb.c
> ____________________________________________________________________________
>
> patch -p0 <<'@@ .'
> Index: rpm/CHANGES
> ============================================================================
> $ cvs diff -u -r1.3487 -r1.3488 CHANGES
> --- rpm/CHANGES 1 Nov 2010 14:44:32 -0000 1.3487
> +++ rpm/CHANGES 1 Nov 2010 19:48:25 -0000 1.3488
> @@ -1,4 +1,6 @@
> 5.3.5 -> 5.4a1:
> + - proyvind: fix issue with 'rpm -qf' on unowned unowned file not being
> + reported. (launchpad #669130)
> - proyvind: fix assert failure with Fadvise() on non-existing files.
> - proyvind: mandriva: fix 'Conflicts: dependencies without release
> misfire'. (mdvbz#55810)
> @@ .
> patch -p0 <<'@@ .'
> Index: rpm/rpmdb/rpmdb.c
> ============================================================================
> $ cvs diff -u -r1.389 -r1.390 rpmdb.c
> --- rpm/rpmdb/rpmdb.c 8 Oct 2010 22:34:11 -0000 1.389
> +++ rpm/rpmdb/rpmdb.c 1 Nov 2010 19:48:25 -0000 1.390
> @@ -2373,6 +2373,7 @@
> #ifdef NOTYET /* XXX JS unit tests break. */
> case RPMTAG_NAME:
> #endif
> + case RPMTAG_PROVIDENAME:
> case RPMTAG_VERSION:
> case RPMTAG_RELEASE:
> case RPMTAG_ARCH:
> @@ .
> ______________________________________________________________________
> RPM Package Manager http://rpm5.org
> CVS Sources Repository rpm-...@rpm5.org
______________________________________________________________________
RPM Package Manager http://rpm5.org
Developer Communication List rpm-devel@rpm5.org
