On Thu, Mar 31, 2011 at 2:01 AM, Michael Jennings <m...@kainx.org> wrote:
> On Wednesday, 30 March 2011, at 18:27:07 (+0200),
> Pinto Elia wrote:
>
> > -%_initddir %{_sysconfdir}/rc.d/init.d
> > # This is a deprecated misspelling, present for backwards
> compatibility.
> > -%_initrddir %{_initddir}
> > +%_initrddir %{_sysconfdir}/rc.d/init.d
> > +%_initddir %{_initrdir}
>
> Two problems here. Setting _initddir based on _initrddir implies that
> the latter is canonical and the former isn't, which is the opposite of
> what's intended.
>
> Second, setting _initddir to the value of _initrdir (that's
> "init r dir" instead of "init rd dir"), which has no value, won't
> work. :-)
>
> The way it was before was preferable, IMHO.
>
> Thanks, there is also a typo - fixed - and i have misread the private
review.
I should not do patch without glass these days :=)
Regards
Elia
