On Apr 10, 2011, at 8:00 PM, Jeff Johnson wrote: > I'm very tempted to just reject this patch: >
And while I'm on a wrant ... There's literally no difference between %(foo ...) and %(echo `foo ...`) like here --- /tmp/O 2011-04-10 19:38:40.465500812 -0400 +++ /tmp/N 2011-04-10 19:38:48.916361766 -0400 @@ -1 +1 @@ -%py_ver %(echo `%{__python} -c "import sys; print sys.version[:3]"`) +%py_ver %(%{__python} -c "import sys; v=sys.version_info[:2]; print '%%d.%%d'%%v" 2>/dev/null || echo PYTHON-NOT-FOUND) Good. You fixed that. What also is in need of fixing is making these "one shot" macros. The values returned are static constants ... there's literally no reason to fork bomb a system just to find out where the python snake is hiding again and again and again and again ... ... yes cpu cycles are cheap! Almost as cheap as stoopid ... 73 de Jeff
smime.p7s
Description: S/MIME cryptographic signature