On Feb 20, 2012, at 8:37 AM, Per Øyvind Karlsen wrote:

>> 
>>  +            o=PyInt_FromLong(he->tag);
>>  +            if (!o) {
>>  +                headerFreeIterator(hi);
> Ehhk!
> This shoulda rather been 'headerFini(hi);'
> 

Fixed.

Meanwhile the real problem here isn't that a merge mistake
was found by vetting, but that there are _NO_ automated tests
for rpm-python that are reliable and might be enabled under
buildbots.

Yes tests exist (from you) but they are not even close to
being able to be run under buildbot's automatically.

73 de Jeff

______________________________________________________________________
RPM Package Manager                                    http://rpm5.org
Developer Communication List                        rpm-devel@rpm5.org

Reply via email to