On Thu, 2016-04-21 at 10:04 -0400, Colin Walters wrote: > On Wed, Apr 20, 2016, at 06:02 AM, Pavel Odvody wrote: > > > > > > That is on my radar, but from experience, people tend to #include > > *much* more than they put into CMakeList.txt or configure.ac -- > > even > > libhif itself doesn't list librepo, > FIND_LIBRARY(REPO_LIBRARY repo REQUIRED) > > > > > GObject, > PKG_CHECK_MODULES(GLIB gio-unix-2.0>=2.44.0 REQUIRED) > > (gobject and glib are transitive dependencies from gio-unix-2.0) > > > > > GObjectIntrospection > That's true, but we're not using it as a C library, but rather via > /usr/bin/g-ir-scanner. >
My bad, the missing piece is that current libhif master requires GLIB >= 2.44.6 because of `g_autoptr(GString)` (so you need at least F23). > > > > others in CMakeList.txt (or there's no version checks) and you just > > need to jump back and forth to figure out what is actually needed > > when > > you're working with some minimal build environment like Docker base > > image. > If I was spending time on this, I would patch build systems like > autotools > and cmake to, when failing to find a pkg-config file, detect the > distribution > and automatically spit out a compatible package name. > > The other thing of course is to look at .spec files and such > upstream, > and in this case since libhif is already packaged, `yum-builddep > libhif`. Yeah, but then there's still tons of C code being compiled on the go every day as part of pip install, gem install etc. and these usually don't even have a Makefile. > _______________________________________________ > Rpm-ecosystem mailing list > [email protected] > http://lists.rpm.org/mailman/listinfo/rpm-ecosystem -- Pavel Odvody <[email protected]> Sr. Software Engineer - EMEA ENG Developer Experience 5EC1 95C1 8E08 5BD9 9BBF 9241 3AFA 3A66 024F F68D Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Rpm-ecosystem mailing list [email protected] http://lists.rpm.org/mailman/listinfo/rpm-ecosystem
