>Another issue I just realized is that with this patch, the metadata hook call 
>is not under the setmeta condition so it will get called always, ie in cases 
>like hardlinks when it specifically should *not* be called :)

>I think the fsm-part should be something like this instead:

@@ -1569,6 +1569,11 @@ static int fsmCommit(FSM_t fsm, int ix, int setmeta)
      }

      if (setmeta) {
+       /* Run fsm metadata hook for all plugins */
+       if (!rc) {
+           rc = rpmpluginsCallFsmFileMetadata(fsm->plugins,
+                                               fsm->path, st, fsm->action);
+       }
          /* Set file security context (if enabled) */
          if (!rc && !getuid()) {
              rc = fsmSetSELabel(fsm->sehandle, fsm->path, fsm->sb.st_mode);

Ups, indeed, will fix!

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to