On Thu, Jun 22, 2017 at 10:20 PM, Darren Hart (VMware) <dvh...@infradead.org> wrote: > Introduce a --disable-bdb configuration option which disables the use of > Berkeley DB entirely. Update the various autotools to ensure that at > least one of BDB or NDB is enabled. Existing configuration options > continue as before. Minor updates to dbi.h and dbi.c to handle bdb being > optional. Add a little extra paranoia to dbi.c which will error out of > the build if neither BDB nor NDB are enabled (which should not be > possible to configure). > > Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org>
So, I tested this patch against rpm git master on MacOS, and while the --enable/--disable for ndb and bdb works when one of them are enabled, the case when both are disabled is surprising. Since your patch doesn't validate the acceptable conditions at the configure.ac level, it accepts it and attempts to build ndb... which fails because missing things on macOS, but that's a different issue. The patch is basically mostly okay, but I would really like to see the configure.ac have logic that prevents creating the makefiles and whatnot if both available rpmdb backends are disabled. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
