ignatenkobrain commented on this pull request.
> + - |
+ if [ "${CONTAINER_IMAGE}" != '' ]; then
+ sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+ fi
+install:
+ - |
+ docker build \
+ -t rpm \
+ .
+before_script:
+ - sudo chown -R 1000 .
+script:
+ - |
+ DIR=$(pwd)
+ docker run \
+ -v "${DIR}:${DIR}" \
I think it's better to copy everything in container in the beginning, isn't it?
(not sure)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50953114_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
