The previous attempt to fail build in case of syntax errors
and unknown dependency qualifiers made in commit
rpm-4.8.0-beta1-385-gbf2bc18ebb325f081ade65adc2fbb6858f0b8396
missed the following classes of erroneous dependencies:
Requires(,) -- erroneously treated as Requires(),
Requires(;) -- erroneously treated as Requires(),
Requires(,pre) -- erroneously treated as Requires(),
Requires(;pre) -- erroneously treated as Requires(),
Requires(pre,) -- erroneously treated as Requires(pre),
Requires(pre,,postun) -- erroneously treated as Requires(pre),
Requires(pre,,junk) -- erroneously treated as Requires(pre),
Requires(pre;postun) -- erroneously treated as Requires(pre),
Requires(pre;junk) -- erroneously treated as Requires(pre).
Found by code inspection.
Fixes: bf2bc18ebb32 ("Always fail build on unknown dependency qualifiers")
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/623
-- Commit Summary --
* tests: check rpmspec --query handling of requirements
* parseBits: disallow syntax errors and unknown qualifiers
-- File Changes --
M build/parsePreamble.c (14)
M tests/Makefile.am (2)
A tests/data/SPECS/test-parsebits.spec (27)
A tests/rpmspec.at (230)
M tests/rpmtests.at (1)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/623.patch
https://github.com/rpm-software-management/rpm/pull/623.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/623
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
