pmatilai commented on this pull request.
>
- ts = rpmtsFree(ts);
+ if (argc == 1)
+ argv[argc++] = "-";
+
+ for (i = 1; i < argc; i++) {
+ rpmts ts = rpmtsCreate();
+ rpmVSFlags vsflags = 0;
+
+ /* XXX retain the ageless behavior of rpm2cpio */
+ vsflags |= RPMVSF_MASK_NODIGESTS;
+ vsflags |= RPMVSF_MASK_NOSIGNATURES;
+ vsflags |= RPMVSF_NOHDRCHK;
+ (void) rpmtsSetVSFlags(ts, vsflags);
+
All this transaction fiddling should be done exactly once, outside the loop.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/681#pullrequestreview-232066019_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint
