pmatilai commented on this pull request.
It might be implemented internally in bash, but generally speaking "[" is an
external command (try 'ls -l /bin/[') and needs to be surrounded by space, and
even in bash it's common good style anyway (see elsewhere in the script). Shell
coding style differs from that of C...
For the same externality reason (ie to avoid fork+exec), the [ command
implements it's own and-operator as -a switch, which is commonly used in
find-debuginfo.sh instead of &&, but that's strictly optional as find-debuginfo
is a bash script.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737#pullrequestreview-245829005
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint