Conan-Kudo requested changes on this pull request.
> @@ -68,12 +68,6 @@ static const int typeSizes[16] = {
0
};
-enum headerSorted_e {
- HEADERSORT_NONE = 0, /* Not sorted */
- HEADERSORT_OFFSET = 1, /* Sorted by offset (on-disk format) */
- HEADERSORT_INDEX = 2, /* Sorted by index */
-};
Why are we getting rid of the enum? It seems we're still using the magic
values, shouldn't we keep the names so we know what they're for?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/870#pullrequestreview-293883494_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
