ffesti commented on this pull request.
> @@ -659,6 +674,10 @@ int main(int argc, char *argv[])
case 's':
ba->buildAmount |= RPMBUILD_PACKAGESOURCE;
break;
+ case 'd':
This looks fishy. The `'r'` case also gets
```
ba->buildAmount |= RPMBUILD_PREP;
```
and I fail to see why this should not be needed here. Basically the only
difference here should be to not fall through to the `'s'` case.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/876#pullrequestreview-318269042_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
