While --define '%foo 1' is often equal to --define 'foo 1', if %foo happens to be already defined, the define expands to that value, completely changing the intent of the --define.
Found due to %source_date_epoch_from_changelog being set in Fedora, causing %source_date_epoch_from_changelog cli define in our reproducable builds test to become --define '1 1' inside a spec build, effectively canceling the effect of the define. What fun! You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1147 -- Commit Summary -- * Fix bunch of tests to not depend on external macro configuration -- File Changes -- M tests/rpmmacro.at (22) M tests/rpmsigdig.at (14) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1147.patch https://github.com/rpm-software-management/rpm/pull/1147.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1147
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint